Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH/SCP/SFTP protocol support #58

Closed
wants to merge 2 commits into from
Closed

Conversation

val314159
Copy link

Uses paramiko library (nice and low level)

Solves: Issue #36

@piskvorky
Copy link
Owner

Thanks a lot @val314159 !

@tmylk please review & prepare for merge.

@ziky90
Copy link
Contributor

ziky90 commented Feb 1, 2016

It looks much better than #44
Though I'm missing some tests in this PR.

@tmylk
Copy link
Contributor

tmylk commented Oct 5, 2016

Tests from #44 need to be added here, then will be ready to merge. Should be a quick win.

Fixes #36 and #33

@val314159
Copy link
Author

I'm not really sure how to test this exactly.... how do i fake out an entire ssh server?

@tmylk
Copy link
Contributor

tmylk commented Dec 1, 2016

Hi @val314159 , thank you for coming back to this!
For mocking one can use mock.patch as in issue 44

@menshikh-iv
Copy link
Contributor

Ping @val314159, what's a status of this PR?

@menshikh-iv
Copy link
Contributor

ping @val314159, what's a status of this PR?

@menshikh-iv
Copy link
Contributor

I close because this PR is abandoned.

@piskvorky
Copy link
Owner

@menshikh-iv looks like only some tests are missing here -- can you add that and merge?

@menshikh-iv
Copy link
Contributor

Need to finish this PR

@menshikh-iv menshikh-iv reopened this Dec 13, 2017
@menshikh-iv
Copy link
Contributor

What's missing:

  • add paramiko dependency (are we fine with it @piskvorky, this is LGPL dependency)
  • parametrize port (ssh not always on 22)
  • add possibility to specify a key
  • resolve merge conflict (this are really large)
  • add tests (unit + integration)
    • check how it works with user/pass, ssh key auth, etc
    • how it works without username at all (only host, is this can retrieve a key from disk?)

anything else missing @mpenkov ?

@piskvorky
Copy link
Owner

Yes, linking against LGPL (without modifications) is fine.

@luckydonald
Copy link

This would come in handy.

@mpenkov
Copy link
Collaborator

mpenkov commented Feb 26, 2019

Continued in #267

@mpenkov mpenkov closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants